Support delta value sorting on string PVs#3508
Merged
Merged
Conversation
shroffk
approved these changes
Aug 13, 2025
Member
|
I think we could create a group of comparators which are smart enough to work with some of our columns which might have multiple types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the save&restore snapshot view, the delta columns supported sorting only on numeric scalar types. Deltas on string PVs where evaluated as zero diff even though they were treated as non-equal.
This PR enhances sorting to consider deltas for string scalar types.